Merged
Conversation
brane-let is compiled on a 24.04 runner, and ubuntu-20.04 is not compatible libc wise
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // Get the base image from the document | ||
| let base = document.base.clone().unwrap_or_else(|| String::from("ubuntu:20.04")); | ||
| // FIXME: We should really make sure that brane-let is compiled on this image as well. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
DanielVoogsgerd
force-pushed
the
small-fixes
branch
from
f4e15e9 to
ca78818
Compare
|
|
||
| // Send a GET-request to the correct location | ||
| let address: String = format!("{}/packages/{}/{}", endpoint, image.name, image.version.as_ref().unwrap_or(&"latest".into())); | ||
| let address: String = format!("http://{}/packages/{}/{}", endpoint, image.name, image.version.as_ref().unwrap_or(&"latest".into())); |
Check warning
Code scanning / devskim
An HTTP-based URL without TLS was detected. Warning
In the tracing related branches -d will be removed. This works on both branches
This URL was incorrect for the nightly release as that release's name is not just the semver representation of the version. Instead in case of nightly (and probably other special versions in the future) this should be the name of the prerelease only
These are triggered when running two package builds at the same time
DanielVoogsgerd
force-pushed
the
small-fixes
branch
from
ca78818 to
c2afd27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.